Adds no wrap for reading time #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reading time used to wrap to a new row, thereby distancing the reading time icon from the duration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading time used to wrap to a new row, thereby distancing the reading time icon from the duration
Summary
I used the default Bootstrap 'text-nowrap' class to make sure that the reading time doesn't wrap to the next line without the icon. I checked this with all window sizes and it seems to work well in Chrome and Safari.
Basic example
new:
old:
Motivation
The old method looked a bit ugly on certain screen sizes (especially mobile and with multiple authors). I also changed the margin-left from reading-time to 1rem, because I think the default is a bit too much. That's why my screenshot might look a little bit different. Nevertheless, I believe that the icon should always be on the same line as the duration.
Checks
npm run test