8000 fix: Download Complete message was covered by navigation bar by joohnq · Pull Request #9372 · thunderbird/thunderbird-android · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

fix: Download Complete message was covered by navigation bar #9372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

fix: Download Complete message was covered by navigation bar #9372

merged 1 commit into from
Jun 23, 2025

Conversation

joohnq
Copy link
Contributor
@joohnq joohnq commented Jun 23, 2025

This PR fixes issue #9338 by adjusting the position of the “Download Complete message” so it’s no longer hidden by the navigation bar on some devices.
The root cause was the lack of proper handling of Window Insets—the system UI areas like the navigation bar that can overlap app content.

@joohnq joohnq requested a review from a team as a code owner June 23, 2025 16:22
@joohnq joohnq requested a review from wmontwe June 23, 2025 16:22
@rafaeltonholo rafaeltonholo requested review from rafaeltonholo and removed request for wmontwe June 23, 2025 16:33
@rafaeltonholo rafaeltonholo mentioned this pull request Jun 23, 2025
Closed
rafaeltonholo
rafaeltonholo approved these changes Jun 23, 2025
View reviewed changes
Copy link
Member
@rafaeltonholo rafaeltonholo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this contribution!

@rafaeltonholo
8000 Copy link
Member

Hi @joohnq, regarding the difference between my changes on #9371 and yours, is that you changed in a place that will potentially cover more ground than mine.

My change was targeted in the Message preview screen, while yours applies to the container. Both works!

@rafaeltonholo rafaeltonholo changed the title fix: resolve #9338 – Download Complete message was covered by navigation bar... fix: Download Complete message was covered by navigation bar Jun 23, 2025
@rafaeltonholo rafaeltonholo added the task: uplift to beta Uplift to the beta branch label Jun 23, 2025
@rafaeltonholo rafaeltonholo self-assigned this Jun 23, 2025
@rafaeltonholo rafaeltonholo linked an issue Jun 23, 2025 that may be closed by this pull request
The “Download Complete Message” button is located behind the bottom navigation bar and cannot be selected #9338
Closed
2 tasks
@rafaeltonholo rafaeltonholo merged commit 2098a2d into thunderbird:main Jun 23, 2025
3 checks passed
@thunderbird-botmobile thunderbird-botmobile bot added this to the Thunderbird 12 milestone Jun 23, 2025
@joohnq joohnq deleted the fix-issue-9338 branch June 23, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaeltonholo rafaeltonholo rafaeltonholo approved these changes

Assignees

@rafaeltonholo rafaeltonholo

Labels
task: uplift to beta Uplift to the beta branch
Projects
None yet
Milestone
Thunderbird 12
Development

Successfully merging this pull request may close these issues.

The “Download Complete Message” button is located behind the bottom navigation bar and cannot be selected
2 participants
@joohnq @rafaeltonholo
0