Replace Direct Calls to K9.isMessageListSenderAboveSubject with PreferenceDataStore integration #9322
+27
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
05730db to
94a511d
Compare
…with preferenceDataStore integration
94a511d to
e09d133
Compare
…or of GeneralSettings in tests
…ect in FakeGeneralSettingsManager
e09d133 to
9b0d3e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thunderbird Android currently uses K9.isMessageListSenderAboveSubject directly in the codebase to determine whether the sender name (instead of the sender email) should appear above the subject in the message list. This approach bypasses the modern preference management system.
This Pull requests aims to refactor all direct usages of
K9.isMessageListSenderAboveSubjectto retrieve the preference viaGeneralSettingsDataStore( an implementation ofPreferenceDataStore).