8000 Add algorithmic darkening for WebView. by terofeev · Pull Request #9080 · thunderbird/thunderbird-android · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add algorithmic darkening for WebView. #9080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

Add algorithmic darkening for WebView. #9080

merged 1 commit into from
Apr 30, 2025

Conversation

terofeev
Copy link
Contributor

Fixes #8992

Apply algorithmic darkening if WebView supports it.
If not, try to use force dark instead.

Also, remove CSS styling for dark mode, as it breaks the new algorithmic darkening.

Result

AlgoD

@kewisch
Copy link
Member
kewisch commented Apr 29, 2025

Someone from my team will review this shortly, thank you for the contribution! Once the jobs pass maybe you could squash commits? I don't think we need a separate commit for linting fixes.

@terofeev terofeev force-pushed the add-algo-darkening-webview branch from f49dc41 to 8fbcee5 Compare April 29, 2025 11:01
@terofeev
Copy link
Contributor Author

Someone from my team will review this shortly, thank you for the contribution! Once the jobs pass maybe you could squash commits? I don't think we need a separate commit for linting fixes.

Hi @kewisch,
thanks for the quick review, I’ve squashed the commits.

One note - the dependencyGuard job failed (logs here).

Should I apply the suggestion and run:
./gradlew :app-thunderbird:dependencyGuardBaseline ?

rafaeltonholo
rafaeltonholo requested changes Apr 29, 2025
View reviewed changes
Copy link
Member
@rafaeltonholo rafaeltonholo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @terofeev, thank you for your contribution! The dark mode rendering has greatly improved with this change!

I have left a few comments for your consideration. Let me know if you have any questions.

@terofeev terofeev force-pushed the add-algo-darkening-webview branch from 8fbcee5 to d041642 Compare April 29, 2025 17:43
@terofeev terofeev requested a review from rafaeltonholo April 29, 2025 17:49
@terofeev
Copy link
Contributor Author

Hi @terofeev, thank you for your contribution! The dark mode rendering has greatly improved with this change!

I have left a few comments for your consideration. Let me know if you have any questions.

Hi @rafaeltonholo,
Thanks for the review! All comments addressed. Appreciate your help!

rafaeltonholo
rafaeltonholo approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member
@rafaeltonholo rafaeltonholo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution!

@terofeev terofeev force-pushed the add-algo-darkening-webview branch from d041642 to 500b4cf Compare April 30, 2025 08:03
@terofeev
Copy link
Contributor Author

@rafaeltonholo the CI build failed due to an outdated unit test related to dark mode:
fun wrapMessageContent_whenDarkMessageViewTheme_addsDarkThemeCSS()
I removed it since it’s no longer needed. Could you review these changes when you have a moment?

@rafaeltonholo rafaeltonholo merged commit de086c9 into thunderbird:main Apr 30, 2025
3 checks passed
@thunderbird-botmobile thunderbird-botmobile bot added this to the Thunderbird 11 milestone Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaeltonholo rafaeltonholo rafaeltonholo approved these changes

@kewisch kewisch Awaiting requested review from kewisch kewisch is a code owner

@wmontwe wmontwe Awaiting requested review from wmontwe wmontwe is a code owner

@asoucar asoucar Awaiting requested review from asoucar asoucar is a code owner

Assignees

@rafaeltonholo rafaeltonholo

Labels
None yet
Projects
None yet
Milestone
Thunderbird 11
Development

Successfully merging this pull request may close these issues.

Dark mode brokes tables with specified colors
3 participants
@terofeev @kewisch @rafaeltonholo
0