8000 Fixes Outlook outgoing server autoconfig failure by rafaeltonholo · Pull Request #9089 · thunderbird/thunderbird-android · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixes Outlook outgoing server autoconfig failure #9089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2025
Merged

Fixes Outlook outgoing server autoconfig failure #9089

merged 2 commits into from
Apr 29, 2025

Conversation

rafaeltonholo
Copy link
Member

Fixes: #8024

The issue mainly occurred when the primary email associated with an account did not match the username used for authenticating to the Outlook SMTP. To resolve this problem, we are now retrieving the primary email included in the OAuth2 tokens to ensure proper authentication with the outgoing server.

Changeset:

  • Migrate OAuth2TokenProvider to Kotlin
  • When available, use the primary email; otherwise, use the given username for authenticating in outgoing servers.

@rafaeltonholo rafaeltonholo force-pushed the fix/8024/outlook-outgoing-server-autoconfig-failure branch 2 times, most recently from cd37231 to 115a019 Compare April 28, 2025 19:45
kewisch
kewisch approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member
@kewisch kewisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me with the few comments considered. We'll want QA to test this with all the remaining OAuth providers. Once merged and in either a daily or beta release, let's get Corey to pass this on to QA.

@kewisch kewisch self-assigned this Apr 29, 2025
@rafaeltonholo rafaeltonholo force-pushed the fix/8024/outlook-outgoing-server-autoconfig-failure branch from 115a019 to e407259 Compare April 29, 2025 15:03
asoucar
asoucar approved these changes Apr 29, 2025
View reviewed changes
Copy link
Contributor
@asoucar asoucar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given your addressing @kewisch 's comments I think the only thing left to do is squash then this is good

@kewisch
Copy link
Member
kewisch commented Apr 29, 2025

Given your addressing @kewisch 's comments I think the only thing left to do is squash then this is good

I think in this case we could leave them separate. The converting works as is. Wolf is preparing some guidelines in #8964 for this.

@rafaeltonholo rafaeltonholo merged commit 895e893 into thunderbird:main Apr 29, 2025
3 checks passed
@thunderbird-botmobile thu 8000 nderbird-botmobile bot added this to the Thunderbird 11 milestone Apr 29, 2025
@rafaeltonholo rafaeltonholo deleted the fix/8024/outlook-outgoing-server-autoconfig-failure branch April 29, 2025 17:09
@kewisch kewisch added the task: uplift to beta Uplift to the beta branch label Apr 29, 2025
@kewisch
Copy link
Member
kewisch commented Apr 29, 2025

[Approval Request Comment]
Original Issue/Pull request: #8024
Regression caused by (issue #):
User impact if declined: Users are not able to log in to Microsoft properties (Hotmail/Outlook) if their account email differs from their mailbox email
Testing completed (on daily, etc.): QA will commence testing as requested on Apr 29th
Risk to taking this patch (and alternatives if risky): If something goes substantially wrong, users will not be able to log in to one of the services in https://github.com/thunderbird/thunderbird-android/blob/main/app-thunderbird/src/beta/kotlin/net/thunderbird/android/auth/TbOAuthConfigurationFactory.kt. Mitigated by having QA test these scenarios.

@coreycb
Copy link
Contributor
coreycb commented May 2, 2025

This was included in today's merge of main->beta

@coreycb coreycb removed the task: uplift to beta Uplift to the beta branch label May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kewisch kewisch kewisch approved these changes

@asoucar asoucar asoucar approved these changes

@wmontwe wmontwe Awaiting requested review from wmontwe wmontwe is a code owner

Assignees

@kewisch kewisch

Labels
None yet
Projects
None yet
Milestone
Thunderbird 11
Development

Successfully merging this pull request may close these issues.

outlook.com outgoing server autoconfig fails
4 participants
@rafaeltonholo @kewisch @coreycb @asoucar
0