Autofill ime option for password managers. #9007
Conversation
|
Blocked as per discussion in #7404 We need androidx.autofill:autofill version 1.3.0 to be released which will also require us to use androidx.compose.ui version 1.8.0, which has also not yet been released. |
|
@wmontwe FYI this issue when you do your dependency update run |
|
We're now using Jetpack Compose 1.8 and could continue with this pull-request. |
# Conflicts: # gradle/libs.versions.toml
|
Merged main branch into my branch. I will mark this pull request as ready for review. Please note that androidx.autofill:autofill is still 1.3.0-rc1 so feel free to wait for stable release. |
|
Personally I think we could risk a rc here, but I'd prefer someone decide that has more experience with Android rc quality. |
|
The only issue I encountered while testing this PR is that the email is not autofilled when using 1Password, although it works fine with Google Password. Additionally, if we decide to implement this in the application, we will need to make a change to the My only concern about introducing an RC version is the risk of the application crashing if an uncaught bug exists before the stable release. However, since the autofill feature is only utilized on two screens during the configuration process and does not affect the input behaviour if autofill is not used, I am comfortable with proceeding. It might also be worth hearing @wmontwe's opinion on this. Let me know your thoughts on this. |
This fixes #7404: Add new account - autofill ime option for password managers. This pull request contains non stable version of androidx.autofill:autofill and androidx.compose.ui:ui package, so it shouldn't be merged yet. As @kewisch mentioned in issue, this pull request should be marked as blocked and it will be merged, when those 2 packages become stable. Will keep an eye on new releases.
Tested with keepass. Attaching screenshots of results: