8000 Message compose: support completion of list of recipients by ruuzia · Pull Request #8994 · thunderbird/thunderbird-android · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Message compose: support completion of list of recipients #8994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025

Conversation

ruuzia
Copy link
Contributor
@ruuzia ruuzia commented Mar 26, 2025

Thank you for creating a wonderful piece of software!
This fixes #5199, which I chose to implement because it was tagged "good first issue".

This PR adds support to the message compose screen for completing entire lists of recipient addresses, rather than just a single address. This way, the user can paste in comma/semicolon delimited address lists. It uses the existing functionality of parsing lists of addresses.

The other way of implementing the feature of pasting in lists of addresses is overriding the paste behavior for the input, and then virtually inserting the pasted characters one by one. However, I considered this method pretty hacky, and I also wanted to use the existing support for parsing lists of addresses.

Unfortunately, this could not be implemented in Kotlin as I was not in the mood to refactor ~2000 lines of Java.

android_thunderbird_compose_paste_list_demo.webm

@wmontwe
Copy link
Member
wmontwe commented Apr 3, 2025

Unfortunately, this could not be implemented in Kotlin as I was not in the mood to refactor ~2000 lines of Java.

Unfortunately, this is on us I guess

Copy link
Member
@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, works great.

@wmontwe wmontwe merged commit 8d1f53d into thunderbird:main Apr 3, 2025
3 checks passed
@thunderbird-botmobile
Copy link
Contributor

Thanks for your contribution! Your pull request has been merged and will be part of Thunderbird 11. We appreciate the time and effort you put into improving Thunderbird. If you haven’t already, you’re welcome to join our Matrix chat for contributors. It’s where we discuss development and help each other out. https://matrix.to/#/#tb-android-dev:mozilla.org
Hope to see you there! 🚀📱🐦

@thunderbird-botmobile thunderbird-botmobile bot added this to the Thunderbird 11 milestone Apr 3, 2025
@kewisch
Copy link
Member
kewisch commented Apr 3, 2025

@ruuzia I know it might be a little bit of extra work, but we would much appreciate if you could take a leap and refactor that file. We're trying to get rid of our remaining java, and it would make a difference!

@ruuzia
Copy link
Contributor Author
ruuzia commented Apr 3, 2025

Sure thing @kewisch, I can jump on that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comma Delimited Copy/Paste Addresses
3 participants
0