8000 Bump AGP 8.7.3 to 8.9.2 by wmontwe · Pull Request #8773 · thunderbird/thunderbird-android · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bump AGP 8.7.3 to 8.9.2 #8773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for Git 8000 Hub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 5, 2025
Merged

Bump AGP 8.7.3 to 8.9.2 #8773

merged 4 commits into from
May 5, 2025

Conversation

wmontwe
Copy link
Member
@wmontwe wmontwe commented Jan 24, 2025 •
edited
Loading

Bumps AGP 8.7.3 to 8.9.2.

Replaces resourceConfigurations by androidResources.localeFilters and changes language code region to ISO 3166-1-alpha-2 region code where needed.

Fixes #8593

@wmontwe wmontwe requested a review from cketti as a code owner January 24, 2025 17:08
@wmontwe wmontwe changed the title Bump agp Bump AGP 8.7.3 to 8.8.0 Jan 24, 2025
@wmontwe
Copy link
Member Author
wmontwe commented Jan 24, 2025

This is not compatible with current Intellij IDEA versions.

@wmontwe wmontwe added the type: dependency Project dependencies label Jan 27, 2025
@wmontwe wmontwe removed the request for review from cketti March 6, 2025 17:10
@kewisch
Copy link
Member
kewisch commented Mar 7, 2025

@wmontwe Is there an IntelliJ issue link to track if this has been resolved? I see some light comments that suggest that this might work by now, but I don't have a definitive answer.

@wmontwe wmontwe requested a review from kewisch as a code owner March 7, 2025 12:25
@wmontwe
Copy link
Member Author
wmontwe commented Mar 7, 2025 •
edited
Loading

@kewisch I'm always testing this when there is a new Intellij IDEA version released, so far it's not working.

This is sadly a long lasting issue that Android Studio and Intellij IDEA diverge on Android Gradle Plugin compatibility.

@wmontwe wmontwe changed the title Bump AGP 8.7.3 to 8.8.0 Bump AGP 8.7.3 to 8.9.2 May 5, 2025
@wmontwe
Copy link
Member Author
wmontwe commented May 5, 2025

This works now with Intellij IDEA 2025.1

@wmontwe wmontwe merged commit 5af7e0e into thunderbird:main May 5, 2025
4 checks passed
@wmontwe wmontwe deleted the bump-agp branch May 5, 2025 14:53
@thunderbird-botmobile thunderbird-botmobile bot added this to the Thunderbird 12 milestone May 5, 2025
@wmontwe wmontwe self-assigned this May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kewisch kewisch kewisch approved these changes

@asoucar asoucar Awaiting requested review from asoucar asoucar is a code owner

@rafaeltonholo rafaeltonholo Awaiting requested review from rafaeltonholo rafaeltonholo is a code owner

Assignees

@wmontwe wmontwe

Labels
type: dependency Project dependencies
Projects
Thunderbird for Android - Sprints
Status: Done
Milestone
Thunderbird 12
Development

Successfully merging this pull request may close these issues.

Support for resourceConfigurations will be removed
2 participants
@wmontwe @kewisch
0