8000 Add zshenv file by rspeicher · Pull Request #289 · thoughtbot/dotfiles · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add zshenv file #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account r 8000 elated emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add zshenv file #289

wants to merge 2 commits into from

Conversation

rspeicher
Copy link
Contributor

From the Zsh manual:

'.zshenv' is sourced on all invocations of the shell, unless the -f option is
set. It should contain commands to set the command search path, plus other
important environment variables. `.zshenv' should not contain commands that
produce output or assume the shell is attached to a tty.

`.zshrc' is sourced in interactive shells. It should contain commands to set up aliases,
functions, options, key bindings, etc.

So why is this important? Alfred workflows run in non-interactive shells. When the $PATH is set or rbenv is initialized in zshrc instead of zshenv, those workflows will not use the correct Ruby version and might not have access to certain bin files, such as those from $HOME/.bin/ or Homebrew.

I've created a simple workflow to demonstrate the problem if you'd like to see for yourselves. Install it and type rbenvtest into Alfred.

Before:
screen shot 2014-07-27 at 11 04 55 pm
After:
screen shot 2014-07-27 at 11 06 35 pm

rspeicher added 2 commits July 27, 2014 22:54
@rspeicher
Add zshenv file
448244d 
From the [Zsh manual](http://zsh.sourceforge.net/Intro/intro_3.html):

> '.zshenv' is sourced on all invocations of the shell, unless the -f option is
> set. It should contain commands to set the command search path, plus other
> important environment variables. `.zshenv' should not contain commands that
> produce output or assu
8000
me the shell is attached to a tty.

Why is this important? [Alfred](http://www.alfredapp.com/) workflows run in
non-interactive shells. When the `$PATH` is set, or `rbenv` is initialized, in
`zshrc` instead of `zshenv`, those workflows will not use the correct Ruby
version and might not have access to certain bin files, such as those from
`$HOME/.bin/` or Homebrew.
@rspeicher
Add zshenv instructions to README
b63fc89
@rspeicher
Copy link
Contributor Author

Hmm, looks like /etc/zshrc on OSX is now modifying the PATH in a way we don't want, with /usr/bin coming before everything else. Not yet sure how to fix that. Apparently only a problem on Mountain Lion.

@mike-burns
Copy link
Contributor

This seems like a good idea. Has anyone run into problems with this change?

@gylaz
Copy link
Contributor
gylaz commented Aug 26, 2014

I have not tried this, but these changes look good.

@gylaz
Copy link
Contributor
gylaz commented Sep 12, 2014

Merged this as 6a1bd18. Thanks @tsigo!

@gylaz gylaz closed this Sep 12, 2014
@rspeicher rspeicher deleted the rs-zshenv branch September 12, 2014 18:59
@rspeicher rspeicher mentioned this pull request Oct 1, 2014
Closed
@mislav mislav mentioned this pull request Oct 16, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rspeicher @mike-burns @gylaz
0