8000 Add missing labels to form elements by WilHall · Pull Request #725 · thoughtbot/constable · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Oct 13, 2021. It is now read-only.

Add missing labels to form elements #725

Merged
merged 3 commits into from
Sep 17, 2019
Merged

Add missing labels to form elements #725

merged 3 commits into from
Sep 17, 2019

Conversation

WilHall
Copy link
Contributor
@WilHall WilHall commented Sep 13, 2019

This PR fixes #684 (with the caveat that addressing Selectize.js inputs has been split out into #724).

Fixes in this PR:

  • Added labels to:
    • Name input in Profile and Settings
    • Comment input on announcement show page
    • Title input on new announcement page
    • Body input on new announcement page
    • Slack channel input
  • Updates some placeholders that were duplicative once the labels were in place

Follow-ups:

@WilHall WilHall added bug When something isn't working correctly accessibility Issues/PRs that address accessibility labels Sep 13, 2019
@WilHall WilHall self-assigned this Sep 13, 2019
tysongach
tysongach approved these changes Sep 14, 2019
View reviewed changes
Copy link
Contributor
@tysongach tysongach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Big accessibility win here. I left a few suggestions…

@tysongach tysongach mentioned this pull request Sep 16, 2019
Closed
WilHall and others added 2 commits September 16, 2019 21:49
@WilHall @tysongach
Label and placeholder updates
a25f214 
Co-Authored-By: Tyson Gach <tyson@tysongach.com>
@WilHall
Normalize labels
35a2bc3
@WilHall WilHall merged commit 6e52abf into master Sep 17, 2019
@WilHall WilHall deleted the feature/form-element-labels branch September 17, 2019 01:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tysongach tysongach tysongach approved these changes

Assignees

@WilHall WilHall

Labels
accessibility Issues/PRs that address accessibility bug When something isn't working correctly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing labels on form elements
2 participants
@WilHall @tysongach
0