8000 Update deploy-workflow.yml by Gkrumbach07 · Pull Request #30 · thoth-station/search · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update deploy-workflow.yml #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2021
Merged

Update deploy-workflow.yml #30

merged 1 commit into from
Dec 14, 2021

Conversation

Gkrumbach07
Copy link
Member
@Gkrumbach07 Gkrumbach07 commented Dec 14, 2021 •
edited
Loading

Related Issues and Dependencies

#29

This introduces a breaking change

  • Yes
  • No

This Pull Request implements

Changes the Deploy workflow to grab the correct secret.

Description

I changed the secret that is used. I tested it on a local branch with the same secret and without it and it should work.

old secret: https://github.com/Gkrumbach07/thoth-search/runs/4521115341?check_suite_focus=true
new secret: https://github.com/Gkrumbach07/thoth-search/runs/4521123095?check_suite_focus=true

@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 14, 2021
@Gkrumbach07 Gkrumbach07 self-assigned this Dec 14, 2021
@Gkrumbach07
Copy link
Member Author

/approve

@sesheta
Copy link
Member
sesheta commented Dec 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2021
@sesheta sesheta merged commit 8a2990c into thoth-station:master Dec 14, 2021
@Gkrumbach07 Gkrumbach07 linked an issue Dec 14, 2021 that may be closed by this pull request
The web app is not able to build from forked PRs #29
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshad16 harshad16 Awaiting requested review from harshad16

@KPostOffice KPostOffice Awaiting requested review from KPostOffice

Assignees

@Gkrumbach07 Gkrumbach07

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The web app is not able to build from forked PRs
2 participants
@Gkrumbach07 @sesheta
0