lottie: use cubics instead of lines #3551
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors Lottie's path-building logic by switching from line commands to cubic commands, simplifying rectangle drawing and rounding of corners.
- Updated signature of the line() function in LottieOffsetModifier to remove the degenerated flag.
- Replaced several direct push of LineTo commands with a new _cubic helper across modifier and builder files.
- Refactored rectangle and star/polygon path methods in LottieBuilder to use cubic commands, reducing special-case handling.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/loaders/lottie/tvgLottieModifier.h | Updated the line() function signature to remove the extra parameter |
| src/loaders/lottie/tvgLottieModifier.cpp | Modified path construction functions (line, corner) to use _cubic helper |
| src/loaders/lottie/tvgLottieBuilder.cpp | Reworked rectangle and star/polygon drawing using cubicTo instead of lineTo |
Comments suppressed due to low confidence (3)
src/loaders/lottie/tvgLottieModifier.h:105
- The removal of the 'bool degenerated' parameter from the line() function signature may affect degenerated case handling; please verify that the new signature preserves the intended behavior.
void line(RenderPath& out, PathCommand* inCmds, uint32_t inCmdsCnt, Point* inPts, uint32_t& curPt, uint32_t curCmd, State& state, float offset);
src/loaders/lottie/tvgLottieBuilder.cpp:646
- [nitpick] Replacing a simple lineTo with cubicTo for straight segments may be confusing to future maintainers; consider adding a comment to explain the rationale behind this change.
shape->cubicTo(SHAPE(shape)->rs.path.pts.last().x, SHAPE(shape)->rs.path.pts.last().y, in.x, in.y, in.x, in.y);
src/loaders/lottie/tvgLottieModifier.cpp:148
- The removal of the previous conditional check on the command type before computing state.line may alter offset adjustments in cases where the previous command was not a LineTo; please confirm that this change is intentional.
state.line = _offset(inPts[curPt - 1], inPts[curPt], offset);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
115 lines added
74 lines removed
(in pucker bloat I can remove 14 lines because of this changes
pros:
cons: