lottie: add lineTo support in round corner alg #3556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, there hasn't been a case where this support was necessary, but it will be once chaining is added- when the LottieRoundnessModifier::modifyPath() is called by a previous modifier.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for handling LineTo commands when applying round corner modifications in Lottie animations, paving the way for future chaining functionality.
- Added conditionals to process LineTo commands by invoking the round corner logic.
- Updated the main switch to include new branches for LineTo command handling with different index arithmetic.
Comments suppressed due to low confidence (1)
src/loaders/lottie/tvgLottieModifier.cpp:234
- [nitpick] It would be beneficial to add inline documentation explaining how _colinear and the subsequent index arithmetic ensure the correct points are used for rounding, as the offset differences could be confusing at first glance.
if (inCmds[iCmds + 1] == PathCommand::CubicTo && _colinear(inPts + iPts)) {
Comment on lines
209
to
+214
| iPts += 3; | ||
| break; | ||
| } else if (inCmds[iCmds + 1] == PathCommand::Close) { | ||
| } | ||
| if (inCmds[iCmds + 1] == PathCommand::LineTo) { | ||
| _roundCorner(path.cmds, path.pts, prev, curr, inPts[iPts + 3], r); | ||
| iPts += 3; |
There was a problem hiding this comment.
[nitpick] The index offset used here (iPts + 3) differs from the one used in the LineTo case (iPts + 1). Consider adding comments to document the rationale behind these differing offsets to improve maintainability.
Copilot uses AI. Check for mistakes.
|
@mgrudzinska do we have any test sample? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, there hasn't been a case where this support was necessary, but it will be once chaining is added- when the LottieRoundnessModifier::modifyPath() is called by a previous modifier.