8000 check `isClosed` before issuing retries for a failed job by deldrid1 · Pull Request #325 · thomasdondorf/puppeteer-cluster · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

check isClosed before issuing retries for a failed job #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

check isClosed before issuing retries for a failed job #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
695cb3a
check `isClosed` before issuing retries for a failed job
deldrid1 Aug 14, 2020
4789b31
Comment cleanup
deldrid1 Aug 14, 2020
4c5fdb8
Fix linter issues and add dist files
deldrid1 Aug 14, 2020
cca71c7
Merge remote-tracking branch 'upstream/master'
deldrid1 Mar 11, 2022
1c18b38
Update to puppeteer 13.5.0
deldrid1 Mar 11, 2022
da5baab
add eslint
deldrid1 Mar 22, 2022
4e50caf
Remove .gitignored files
deldrid1 Mar 22, 2022
50b7773
lint fixes + add 5 second timeout for close events
deldrid1 Mar 22, 2022
83da45e
Free the page (which exists) and not the context (which is undefined)…
deldrid1 Mar 24, 2022
f69ada7
Bump to latest version of puppeteer and move createIncognitoBrowserCo…
deldrid1 Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
node_modules
dist
examples/typings.ts
test
22 changes: 22 additions & 0 deletions .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{
"root": true,
"parser": "@typescript-eslint/parser",
"parserOptions": {
"sourceType": "module",
"ecmaVersion": 2020,
"project": "tsconfig.json"
},
"plugins": [
"@typescript-eslint"
],
"extends": [
"eslint:recommended",
"plugin:@typescript-eslint/eslint-recommended",
"plugin:@typescript-eslint/recommended"
],
"rules": {
"@typescript-eslint/no-floating-promises": "error",
"@typescript-eslint/no-misused-promises": "error",
"@typescript-eslint/no-explicit-any": "off" // Remove the noise for now
}
}
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
# Changelog
All notable changes to this project will be documented in this file.

### Fixed
- `cluster.close()` will actually close the cluster when `retryLimit !== 0` and the number of tries has not exhausted the retries.

## [0.23.0] - 2022-01-23
### Changed
- Updated dependencies which haven't been updated for more than one year
Expand Down
Loading
0