bridge_info: implement missing rtnl_link_info_ops::io_clone() #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Link info ops that use link info also need to implement rtnl_link_info_ops::io_clone(), else cloning the link will result in a broken object, and trying to use any rtnl_link_bridge_*() accessors will result in a null pointer access due to rtnl_link::l_info not being taken over. So implement the missing rtnl_link_info_ops::io_clone() callback. Fixes: 7391a38 ("bridge: Add support for link_info of a bridge") Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
thom311
pushed a commit
that referenced
this pull request
Jun 3, 2025
Link info ops that use link info also need to implement rtnl_link_info_ops::io_clone(), else cloning the link will result in a broken object, and trying to use any rtnl_link_bridge_*() accessors will result in a null pointer access due to rtnl_link::l_info not being taken over. So implement the missing rtnl_link_info_ops::io_clone() callback. Fixes: 7391a38 ("bridge: Add support for link_info of a bridge") Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de> #426
|
merged. Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per
2E37
line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link info ops that use link info also need to implement
rtnl_link_info_ops::io_clone(), else cloning the link will result in a broken object, and trying to use anyrtnl_link_bridge_*()accessors will result in a null pointer access due tortnl_link::l_infonot being taken over.So implement the missing
rtnl_link_info_ops::io_clone()callback.Fixes: 7391a38 ("bridge: Add support for link_info of a bridge")