client: Fix tooltipped instances by moving class to interactive elements #4937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2df9f54 to
346b55a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4865.
The current problems faced with the
tooltippedCSS are discussed somewhat in #4865; this PR takes the approach of correcting usage in several instances so that thetooltippedclass is applied to the interactive element (rather than e.g. a wrapping div or span).Correcting this has the following effects:
aria-labelno longer needs to be duplicated, as it is now on the one element that matters both in terms of CSS and interactivityThe few CSS changes in this PR allow icons to continue working, and prevent opacity changes from affecting the tooltip.
This PR intentionally does not cover all
tooltippedinstances. I have more work covering the rest that I would rather PR separately, as it also includes more interactivity fixes (for keyboard and e.g. screen readers) that overlap with the same elements. I wanted to send the more straightforward non-intertwined part first. Relatedly, I don't claim to also fix #4866 with this PR - that'll be covered in the other part.