Pull in SortableJS from NPM again. #4540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SortableJS/Sortable#2095 has been merged so we no longer need to use our fork.
|
I haven't gone and actually given this a proper test on Android yet but will hopefully get to it before too long. |
MaxLeiter
approved these changes
Apr 18, 2022
|
@itsjohncs feel free to merge whenever you've tested it 👍 |
|
Tested on Android and couldn't reproduce the "lose next tap after long-tap" bug so calling this good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SortableJS/Sortable#2095 has been merged so we no longer need to use
our fork.