Permissions #4373
Merged
Permissions #4373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxLeiter
requested changes
Nov 25, 2021
MaxLeiter
approved these changes
Nov 27, 2021
MaxLeiter
requested changes
Nov 29, 2021
Contains a secret key, so we probably should keep it, well, secret. Warn if the file is world readable.
When TL first creates the log folder, let only the user read the log files, should the admin override that subsequently we'll simply warn about it but respect the decision. Meaning we have private by default, but this can be overriden
dd666cb to
0ff9703
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still have some issues related to packaging.
That's essentially the issue raised at thelounge/thelounge-deb#72
However the issue is persistent over all installation methods and should be fixed in core.
Rather than messing with the filesystem and trying to fix the mess we created we simply warn and let the admins handle it.
While not ideal, at least that solves the issue for new installs and we can always fix it in the packages of the more opinionated packages (read Debian) and maybe warn on do it yourself distros (Arch)