8000 Small cleanup of messageStorage/sqlite. by itsjohncs · Pull Request #4345 · thelounge/thelounge · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Small cleanup of messageStorage/sqlite. #4345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2021
Merged

Small cleanup of messageStorage/sqlite. #4345

merged 1 commit into from
Nov 3, 2021

Conversation

itsjohncs
Copy link
Member
  • Extend test coverage to the search function.
  • Test sort order of messages from getMessages and search
  • Move reversal of search results from Vue to messageStorage.
  • Remove unnecessary uses of sqlite.serialize in tests.
  • Return promises from test functions where possible.

--

These changes were originally in #4334.

@itsjohncs
Small cleanup of messageStorage/sqlite.
044cd24 
* Extend test coverage to the `search` function.
* Test sort order of messages from `getMessages` and `search`
* Move reversal of `search` results from Vue to messageStorage.
* Remove unnecessary uses of `sqlite.serialize` in tests.
* Return promises from test functions where possible.
@MaxLeiter MaxLeiter merged commit 0381cd1 into thelounge:master Nov 3, 2021
@MaxLeiter
Copy link
Member

Thanks @itsjohncs and @Nachtalb!

@MaxLeiter MaxLeiter added this to the 4.3.0 milestone Nov 4, 2021
@MaxLeiter MaxLeiter added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Nov 4, 2021
@MaxLeiter MaxLeiter mentioned this pull request Nov 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxLeiter MaxLeiter MaxLeiter approved these changes

Assignees
No one assigned
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@itsjohncs @MaxLeiter
0