8000 Change the IRC server to Libera.Chat by mhajder · Pull Request #4238 · thelounge/thelounge · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Change the IRC server to Libera.Chat #4238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 26, 2021
Merged

Change the IRC server to Libera.Chat #4238

merged 4 commits into from
May 26, 2021

Conversation

mhajder
Copy link
Contributor
@mhajder mhajder commented May 23, 2021

I changed all references from Freenode to Libera.Chat due to the main channel being moved to the Libera.Chat network.
I haven't changed anything in the tests folder.

@richrd
Copy link
Member
richrd commented May 26, 2021

Some tests didn't pass, they need to be fixed too. For example AssertionError: expected 'irc.libera.chat' to equal 'chat.freenode.net'

@xPaw
Copy link
Member
xPaw commented May 26, 2021 •
edited
Loading

While you're going to fix tests, you might as well replace usages of "Freenode" with something generic like "IRC Server".

And to fix the reliance of tests on the default config, you could assign the default hostname to something generic as well (irc.example.com), in this test:

thelounge/test/models/network.js

Line 82 in 0fb6dae

Helper.config.lockNetwork = true;

You can change the default host/name in this file for all tests:
https://github.com/thelounge/thelounge/blob/master/test/fixtures/.thelounge/config.js

config.defaults.name = "Example IRC Server";
config.defaults.host = "irc.example.com";

@xPaw xPaw added the Meta: Internal This is an internal codebase change (testing, linting, etc.). label May 26, 2021
@xPaw xPaw added this to the 4.3.0 milestone May 26, 2021
@mhajder
Copy link
Contributor Author
mhajder commented May 26, 2021

I would like to ask you to check if this is what you meant. I didn't quite understand what I was supposed to do, so I changed the default network name and some channels to a more generic.

You could still change this file. Unfortunately, I have no idea what name to change to.
https://github.com/thelounge/thelounge/blob/master/test/tests/textLogFolder.js#L6-L42

xPaw
xPaw reviewed May 26, 2021
View reviewed changes
@xPaw
Copy link
Member
xPaw commented May 26, 2021

Changes look correct to me (sans one mistake). The textLogFolder file is fine to keep as is, all it is doing is testing folder name generation.

@xPaw xPaw linked an issue May 26, 2021 that may be closed by this pull request
Move demo and support channels to Libera Chat. #4233
Closed
@xPaw xPaw merged commit fa854fd into thelounge:master May 26, 2021
@MaxLeiter MaxLeiter mentioned this pull request Nov 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xPaw xPaw xPaw approved these changes

@MaxLeiter MaxLeiter MaxLeiter approved these changes

Assignees
No one assigned
Labels
Meta: Internal This is an internal codebase change (testing, linting, etc.).
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

Move demo and support channels to Libera Chat.
4 participants
@mhajder @richrd @xPaw @MaxLeiter
0