Make add and reset CLI commands scriptable
#4090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@flying-sausages Can you give this a try to see if it works correctly for you? |
igalic
reviewed
Oct 4, 2020
src/command-line/users/add.js
Outdated
| ) | ||
| .option( | ||
| "--save-logs", | ||
| "if password is specified on command line, this will effect if logs for this user will be saved on disk" |
There was a problem hiding this comment.
i think this should be "affect", not "effect"
but even so, i still don't understand what this option does
There was a problem hiding this comment.
if password is specified, this enables saving logs to disk
There was a problem hiding this comment.
only if a password is specified, this enables saving (a user's) logs to disk
xPaw
reviewed
Oct 5, 2020
src/command-line/users/add.js
Outdated
| .action(function (name) { | ||
| .option( | ||
| "--password [password]", | ||
| "new password, will be prompted if not specified on command line" |
|
Oops, didn't mean to click on close. I've improved the wording on both of the options based on your feedback. |
igalic
approved these changes
Oct 6, 2020
xPaw
approved these changes
Oct 6, 2020
|
Do you mind squashing your commits into one please. |
Add CLI options `--password` and `--save-logs` (for `add` only) in order to make adding users and changing user passwords scriptable. Closes thelounge#3913
0713ef5 to
e790a72
Compare
done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CLI options
--passwordand--save-logs(foraddonly) in order to make adding users and changing user passwords scriptable.Closes #3913.