Use colorable to support Windows terminals; remove vendor/ directory #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
=======================================
Coverage 94.51% 94.51%
=======================================
Files 2 2
Lines 529 529
=======================================
Hits 500 500
Misses 15 15
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
d5d016f to
6f9022c
Compare
This change adds a direct dependency on `github.com/mattn/go-colorable` to support Windows terminals, and removes the plumbing that hardcodes Windows as a dumb terminal. This is inspired by #32 opened by @OtisOat. This also removes the `vendor/` directory, as it's even less valuable with our usage of Modules. Closes #32
6f9022c to
e5c32e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a direct dependency on
github.com/mattn/go-colorabletosupport Windows terminals, and removes the plumbing that hardcodes Windows as a
dumb terminal. This is inspired by #32 opened by @OtisOat.
This also removes the
vendor/directory, as it's even less valuable with ourusage of Modules.
Closes #32