8000 feat: extend schema descriptions by jasonkuhrt · Pull Request #9 · the-guild-org/polen · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: extend schema descriptions #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Apr 14, 2025
Merged

feat: extend schema descriptions #9

merged 26 commits into from
Apr 14, 2025

Conversation

jasonkuhrt
Copy link
Member
@jasonkuhrt jasonkuhrt commented Apr 11, 2025 •
edited
Loading

closes #4

@jasonkuhrt
Copy link
Member Author
jasonkuhrt commented Apr 12, 2025 •
edited
Loading

Blocked by this development error on examples, tried debugging but ran out of time. Will need to revisit this on Monday.

When I pnpm link ../.. from an example, this error does not happen. It seems to be happening with the registry version of Polen too. Need to confirm when I am going less quickly, next session.

Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons:
1. You might have mismatching versions of React and the renderer (such as React DOM)
2. You might be breaking the Rules of Hooks
3. You might have more than one copy of React in the same app
See https://react.dev/link/invalid-hook-call for tips about how to debug and fix this problem.
Error: Failed to server side render the HTML
    at Array.eval (/Users/jasonkuhrt/projects/the-guild-org/polen/examples/github/node_modules/.pnpm/polen@file+..+.._vite@6.2.6/node_modules/polen/build/app-template/entry.server.jsx:79:11)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async file:///Users/jasonkuhrt/projects/the-guild-org/polen/examples/github/node_modules/.pnpm/polen@file+..+.._vite@6.2.6/node_modules/polen/build/vite-plugin/vite-plugin.js:64:46
    at async responseViaResponseObject (file:///Users/jasonkuhrt/projects/the-guild-org/polen/examples/github/node_modules/.pnpm/@hono+node-server@1.14.1_hono@4.7.6/node_modules/@hono/node-server/dist/index.mjs:372:13)
    at async file:///Users/jasonkuhrt/projects/the-guild-org/polen/examples/github/node_modules/.pnpm/@hono+node-server@1.14.1_hono@4.7.6/node_modules/@hono/node-server/dist/index.mjs:467:14 {
  [cause]: TypeError: Cannot read properties of null (reading 'useContext')
      at process.env.NODE_ENV.exports.useContext (/Users/jasonkuhrt/projects/the-guild-org/polen/examples/github/node_modules/.pnpm/react@19.1.0/node_modules/react/cjs/react.development.js:1168:25)
      at useInRouterContext (/Users/jasonkuhrt/projects/the-guild-org/polen/examples/github/node_modules/.pnpm/react-router@7.5.0_react-dom@19.1.0_react@19.1.0__react@19.1.0/node_modules/react-router/dist/development/index.js:4754:17)
      at Router (/Users/jasonkuhrt/projects/the-guild-org/polen/examples/github/node_modules/.pnpm/react-router@7.5.0_react-dom@19.1.0_react@19.1.0__react@19.1.0/node_modules/react-router/dist/development/index.js:5669:6)
      at react-stack-bottom-frame (/Users/jasonkuhrt/projects/the-guild-org/polen/node_modules/.pnpm/react-dom@19.1.0_react@19.1.0/node_modules/react-dom/cjs/react-dom-server-legacy.node.development.js:8970:18)
      at renderWithHooks (/Users/jasonkuhrt/projects/the-guild-org/polen/node_modules/.pnpm/react-dom@19.1.0_react@19.1.0/node_modules/react-dom/cjs/react-dom-server-legacy.node.development.js:4699:19)
      at renderElement (/Users/jasonkuhrt/projects/the-guild-org/polen/node_modules/.pnpm/react-dom@19.1.0_react@19.1.0/node_modules/react-dom/cjs/react-dom-server-legacy.node.development.js:5134:23)
      at retryNode (/Users/jasonkuhrt/projects/the-guild-org/polen/node_modules/.pnpm/react-dom@19.1.0_react@19.1.0/node_modules/react-dom/cjs/react-dom-server-legacy.node.development.js:5899:31)
      at renderNodeDestructive (/Users/jasonkuhrt/projects/the-guild-org/polen/node_modules/.pnpm/react-dom@19.1.0_react@19.1.0/node_modules/react-dom/cjs/react-dom-server-legacy.node.development.js:5849:11)
      at renderElement (/Users/jasonkuhrt/projects/the-guild-org/polen/node_modules/.pnpm/react-dom@19.1.0_react@19.1.0/node_modules/react-dom/cjs/react-dom-server-legacy.node.development.js:5586:15)
      at retryNode (/Users/jasonkuhrt/projects/the-guild-org/polen/node_modules/.pnpm/react-dom@19.1.0_react@19.1.0/node_modules/react-dom/cjs/react-dom-server-legacy.node.development.js:5899:31)
}

@jasonkuhrt
Copy link
Member Author

Interesting, when the example has react-dom installed rather than it being a dep of Polen, then the error goes away...
8000

@jasonkuhrt
Copy link
Member Author

Dev is fixed but build is not.

@jasonkuhrt
Copy link
Member Author

Oh, adding react-dom fixes dev but breaks build.

@jasonkuhrt jasonkuhrt merged commit 91d067c into main Apr 14, 2025
4 of 5 checks passed
@jasonkuhrt jasonkuhrt deleted the feat/dp-58-arbitrary-content-attachment-to-types branch April 14, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Arbitrary content attachment to types
1 participant
@jasonkuhrt
0