8000 Catch missing project level deps bug in e2e tests · Issue #12 · the-guild-org/polen · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Catch 8000 missing project level deps bug in e2e tests #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jasonkuhrt opened this issue Apr 14, 2025 · 4 comments · Fixed by #13
Closed

Catch missing project level deps bug in e2e tests #12

jasonkuhrt opened this issue Apr 14, 2025 · 4 comments · Fixed by #13
Assignees
@jasonkuhrt
Labels
test

Comments

@jasonkuhrt
Copy link
Member

Our e2e tests do not catch #11. They should.
@jasonkuhrt jasonkuhrt self-assigned this Apr 14, 2025
@jasonkuhrt
Copy link
Member Author

Ideas:

  1. Remove development deps of Polen (or move examples to a non-nested directory) so that node module resolution doesn't traverse into them.
  2. Stop using pnpm link in CI. Instead us pnpm add ../...

I believe (1) is a must. I am not sure (2) is needed or even helpful.

@jasonkuhrt
Copy link
Member Author

I am able to repro in examples by removing project node_modules:

10:10:33 AM [vite] (ssr) Error when evaluating SSR module /Users/jasonkuhrt/projects/the-guild-org/polen/examples/basic/node_modules/.pnpm/polen@0.2.0-next.1_vite@6.2.6/node_modules/polen/build/app-template/entry.server.jsx: Cannot find module 'react/jsx-dev-runtime' imported from '/Users/jasonkuhrt/projects/the-guild-org/polen/examples/basic/node_modules/.pnpm/polen@0.2.0-next.1_vite@6.2.6/node_modules/polen/build/app-template/entry.server.jsx'

But to run tests I need those deps. One clean way to do this is first copy the example to a temporary directory to make break the directory nesting which confuses our tooling. For example I got this unexpected error while running Vite in the example too:

Image

Apparently the example Vite is trying to interact with an ancestor tsconfig file. Didn't even know it was, not good.

@jasonkuhrt
Copy link
Member Author

Hitting PW fixture issues ... https://discord.com/channels/807756831384403968/1361366612627820624

@jasonkuhrt jasonkuhrt mentioned this issue Apr 14, 2025
Merged
@jasonkuhrt
Copy link
Member Author

Resolved, issue was my misunderstanding about PW workers. If a fixture fails, the worker is re-created thus leading to worker-scoped fixtures also being recreated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonkuhrt jasonkuhrt

Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(examples): catch missing dep error the-guild-org/polen
1 participant
@jasonkuhrt
0