8000 vite plugin considers only project level deps · Issue #11 · the-guild-org/polen · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

vite plugin considers only project level deps #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jasonkuhrt opened this issue Apr 14, 2025 · 2 comments · Fixed by #14
Closed

vite plugin considers only project level deps #11

jasonkuhrt opened this issue Apr 14, 2025 · 2 comments · Fixed by #14
Assignees
@jasonkuhrt
Labels
bug Something isn't working

Comments

@jasonkuhrt
Copy link
Member
  • When using Polen vite plugin and running Vite dev build etc., then...
  • Polen source code imports of react, react-dom, hono, ... are not
    resolved because these deps are not hoisted by pnpm (correct).
  • The problem is that the CLI is bringing source code from Polen to be run in the context of the project.
  • I am not sure how to solve this.
@jasonkuhrt jasonkuhrt added the bug Something isn't working label Apr 14, 2025
@jasonkuhrt jasonkuhrt self-assigned this Apr 14, 2025
@jasonkuhrt jasonkuhrt removed the bug Something isn't working label Apr 14, 2025
@jasonkuhrt jasonkuhrt added the bug Something isn't working label Apr 14, 2025 — with Linear
@jasonkuhrt Linear
Copy link
Member Author

Our e2e example tests do not accurately catch this bug. That is a sub-issue

@jasonkuhrt jasonkuhrt mentioned this issue Apr 14, 2025
Closed
@jasonkuhrt jasonkuhrt reopened this Apr 14, 2025
@jasonkuhrt
Copy link
Member Author

vitejs/vite#19865

@jasonkuhrt jasonkuhrt mentioned this issue Apr 14, 2025
Merged
This was referenced Apr 14, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonkuhrt jasonkuhrt

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: react and react-dom peer deps the-guild-org/polen
1 participant
@jasonkuhrt
0