8000 Provide a regex filter to "latest", and provide "latest" with filter to "tfenv use" by Zordrak · Pull Request #33 · tfutils/tfenv · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Provide a regex filter to "latest", and provide "latest" with filter to "tfenv use" #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 8, 2017

Conversation

Zordrak
Copy link
Collaborator
@Zordrak Zordrak commented Mar 6, 2017

I've been a bit savage with the bash code for my own standards, changing some naming, removing set -e where appropriate, replacing with error trapping. Standardising the error_and_die function etc, and rewording some of the errors, so you probably won't want to accept this PR as-is; however you might be interested in the way I have included a regex filter for "latest" and an option for a filtered "latest" for use to allow you to be more specific about the versions you want to match.

e.g. if you want to not upgrade to v0.9 yet:

tfenv install latest:^0.8
tfenv use latest:^0.8

@kamatama41
Copy link
Collaborator
kamatama41 commented Mar 8, 2017

@Zordrak
Thank you for your contribution and refactoring!
Since I'm not actually familiar with Bash (and English.. 😓 ), I was able to extend my knowledge with this PR! However, a test fails and README becomes your repository's one, so I've created a follow-up PR ( #34 ), please check it, thanks 😃

@kamatama41 kamatama41 mentioned this pull request Mar 8, 2017
@kamatama41 kamatama41 merged commit 204a7e2 into tfutils:master Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0