8000 Version control integration not working · Issue #19 · texttest/texttest · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Version control integration not working #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasio 8000 nally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gjb1002 opened this issue Jan 23, 2019 · 8 comments
Open

Version control integration not working #19

gjb1002 opened this issue Jan 23, 2019 · 8 comments

Comments

@gjb1002
Copy link
Collaborator
gjb1002 commented Jan 23, 2019

Just comes silently disabled in the GUI. Suspect some exception is being caught and conclusions are being drawn that it should not be used.
behrisch added a commit that referenced this issue Feb 19, 2019
@behrisch
fixing version control module imports, refs #19
3de2322
@behrisch
Copy link
Collaborator

@gjb1002 please recheck, I only tested git here

behrisch added a commit that referenced this issue Feb 19, 2019
@behrisch
fixing typo, refs #19
23aca2c
@gjb1002
Copy link
Collaborator Author
gjb1002 commented Feb 20, 2019

I get a Git menu showing now, but trying to e.g. select "Git log" produces

Traceback (most recent call last):
File "C:\Python34\lib\site-packages\texttestlib\default\gtkgui\guiplugins.py", line 317, in runInteractive
self._runInteractive()
File "C:\Python34\lib\site-packages\texttestlib\default\gtkgui\guiplugins.py", line 326, in _runInteractive
self.startPerform()
File "C:\Python34\lib\site-packages\texttestlib\default\gtkgui\guiplugins.py", line 344, in startPerform
self.performOnCurrent()
File "C:\Python34\lib\site-packages\texttestlib\default\gtkgui\guiplugins.py", line 514, in performOnCurrent
self.addContents()
File "C:\Python34\lib\site-packages\texttestlib\default\gtkgui\version_control\vcs_independent.py", line 419, in addContents
self.addTreeView()
File "C:\Python34\lib\site-packages\texttestlib\default\gtkgui\version_control\vcs_independent.py", line 509, in addTreeView
textView = Gtk.TextView(self.textBuffer)
TypeError: GObject.init() takes exactly 0 arguments (1 given)

@gjb1002
Copy link
Collaborator Author
gjb1002 commented Feb 20, 2019

Same goes for Mercurial and Bazaar: menus come up fine, so the checked in changes are correct, but then I get the above stack trace when trying to do anything from the GUI.

@gjb1002
Copy link
Collaborator Author
gjb1002 commented Feb 20, 2019 •
edited
Loading

(There is a question whether version-control integration really adds anything to TextTest these days. I personally prefer to use dedicated GUIs like SourceTree and GitExtensions now, which are far better than they were 10 years ago. At least we should probably drop support for bzr when TextTest itself has moved away from it, and maybe hg too which I also think is losing the battle.)

Have now been using TextTest with Git integration broken for a couple of months, and really haven't missed it...

behrisch added a commit that referenced this issue Feb 20, 2019
@behrisch
fixing text view in version control, refs #19
6c509d0
@behrisch
Copy link
Collaborator

I did not try any menu items so this one just slipped through and was easy to fix. I like the log view here but beside that I agree with you.

@gjb1002
Copy link
Collaborator Author
gjb1002 commented Feb 20, 2019

I now get this stacktrace instead:

Traceback (most recent call last):
File "C:\Python34\lib\site-packages\texttestlib\default\gtkgui\guiplugins.py", line 317, in runInteractive
self._runInteractive()
File "C:\Python34\lib\site-packages\texttestlib\default\gtkgui\guiplugins.py", line 326, in _runInteractive
self.startPerform()
File "C:\Python34\lib\site-packages\texttestlib\default\gtkgui\guiplugins.py", line 344, in startPerform
self.performOnCurrent()
File "C:\Python34\lib\site-packages\texttestlib\default\gtkgui\guiplugins.py", line 514, in performOnCurrent
self.addContents()
File "C:\Python34\lib\site-packages\texttestlib\default\gtkgui\version_control\vcs_independent.py", line 419, in addContents
self.addTreeView()
File "C:\Python34\lib\site-packages\texttestlib\default\gtkgui\version_control\vcs_independent.py", line 517, in addTreeView
self.createTreeView()
File "C:\Python34\lib\site-packages\texttestlib\default\gtkgui\version_control\vcs_independent.py", line 546, in createTreeView
utfContent = guiutils.convertToUtf8(content)
AttributeError: 'module' object has no attribute 'convertToUtf8'

behrisch added a commit that referenced this issue Feb 20, 2019
@behrisch
fixing log display in version control, refs #19
617ad1e
@gjb1002
Copy link
Collaborator Author
gjb1002 commented Feb 21, 2019

Seems to work now. Tested Git, Mercurial and Bazaar logs and most other menu items on Git.
The only thing that didn't work was the "Graphical Differences" button in the Differences view, but that seems to fail in the same way on the Python 2 version, not sure it's ever worked on Windows. Shows how much that functionality is appreciated :)

@behrisch
Copy link
Collaborator

I will have a short look on that one when I'm back on windows but if it is not used we can also remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@behrisch @gjb1002
0