Actually support MS Edge out-of-box #1872
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update known-browsers with edgeArgs and headlessEdgeArgs to fully support MS Edge with zero user config implement "app=" browser config switch in edgeArgs to launch test page in edge add "new" value to --headless switch for Headless Edge
1c841ab to
1370764
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks, right now, testem does not work with MS Edge out-of-the-box. I contract with a company which does not support Chrome or Firefox, and I need to launch ember-cli qunit tests in MS Edge locally and on a ci server. However, as this repo currently stands, local Edge does not navigate to the test html page after a browser instance is launched, either headless or with a UI. Edge is also not properly configured to work in headless mode. I know I could probably create a complex node-based solution to launch Edge separately and work around this shortcoming, but testem claims to support all major browsers out-of-the-box.
After working this for several days, I have determined that Edge needs an "--app={url}" switch passing the full test page url in order to work. I looked for any possible way to pass an
--app=http://localhost:7357/354104210191250/tests/index.html?hidepassed(of course the url is dynamic) switch to Edge in my local config, but was defeated at every step by the code. Alteringknown-browsersto actually support Edge with anedgeArgsobject seems to be the most direct solution, and it makes good on your promise to support all major browsers. Neither testem's config files, norbefore_testshook has the full test page url available as a parameter to pass to Edge as a command line switch. To fix headless Edge, Edge's switches need--headless=newpassed-in, since the Chrome implementation--headless(with no value) does not work in Edge.I'm surprised to see testem has been updated to support Brave, which could not be considered a "major browser" at this time, but the same amount of (minimal) customization to support Edge has not been implemented in testem, which clearly is a "major browser."
Please merge this pull request to actually support MS Edge, out-of-the-box, with zero user config.