You have a global leak: __core-js_shared__
#364
Comments
|
I presume this is because we pull in common-tags, which pulls in babel-runtime, which pulls in core-js, which probably sets that global. I would rather common-tags didn't pull in babel-runtime, but I don't think this is hurting anything. |
|
@searls thanks for the response. This is a regression from 3.7.0, if a dependency changed thats causing this issue are you open to pinning to the version of the dependency that doesn't leak into the globals? |
|
common-tags is a new dependency as of 3.8.0, one I've been intending to add for a while, because multiline messages are all over this codebase and I'm trying to make it easier to add more of them by stripping indents. One question and three options. Question: is the existence of this transitive dep dropping something on Options:
Seeing as core-js is installed 7M times per week and depended on by 5700+ open source packages, I think that's probably the place to raise the issue if the root cause worry is that a variable is being set to Like I said earlier, I'd like to be rid of the dep as well, and think common-tags would be a stronger tool without needing babel-runtime. I'd also be happy to merge in or publish a standalone indent-stripping heredoc template tag function. |
|
As a point of order, I appreciate you opening the issue to express your concern, but titles that single people out (e.g. "You have…") and issues with empty descriptions that don't explain the nature of the problem caused are often perceived as flippant or rude. Receiving them makes me less eager to help folks or empathize with the issues they're raising, especially if they don't impact me personally. In the future, I'd really appreciate it if you put more detail about the impact of the issue is having on you and any suggestions you might have in issue description. Even if it feels obvious or duplicative, it's less likely to come across as entitled and less likely to make the maintainer feel like your order-taker. |
No description provided.
The text was updated successfully, but these errors were encountered: