8000 Fix sighting context post-processing by 0snap · Pull Request #112 · tenzir/threatbus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on May 29, 2024. It is now read-only.

Fix sighting context post-processing #112

Merged
merged 5 commits into from
Apr 26, 2021
Merged

Fix sighting context post-processing #112

merged 5 commits into from
Apr 26, 2021

Conversation

0snap
Copy link
Contributor
@0snap 0snap commented Apr 26, 2021 •
edited
Loading

📔 Description

Fix a bug with sighting context post-processing (both custom sinks and context transformation).

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/threatbus, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Enable both live- and retro-matching and test interactively by passing sighting context into fever alertify (use example config).

@0snap 0snap marked this pull request as ready for review April 26, 2021 10:27
@0snap 0snap changed the base branch from master to story/ch24760 April 26, 2021 10:28
tobim
tobim reviewed Apr 26, 2021
View reviewed changes
dominiklohmann
dominiklohmann reviewed Apr 26, 2021
View reviewed changes
Base automatically changed from story/ch24760 to master April 26, 2021 11:00
@0snap 0snap force-pushed the topic/fix-sighting-context-mangling branch from f8096ae to 6d72c38 Compare April 26, 2021 11:06
@0snap 0snap force-pushed the topic/fix-sighting-context-mangling branch from 6d72c38 to b0df216 Compare April 26, 2021 11:08
dominiklohmann
dominiklohmann approved these changes Apr 26, 2021
View reviewed changes
Copy link
Member
@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This took me a while to get running, but it seems to work. Not sure if I tested everything, but I managed to go use the previously defunct options.

There's one spelling mistake in the changelog entry, and I'd like to see a new story for creating an integration test for this feature so it's not as complicated to test. Afterwards feel free to merge.

@dominiklohmann dominiklohmann added the bug Incorrect behavior label Apr 26, 2021
@0snap 0snap force-pushed the topic/fix-sighting-context-mangling branch from b0df216 to 5e86c7c Compare April 26, 2021 12:35
@0snap 0snap merged commit bcf64da into master Apr 26, 2021
@0snap 0snap deleted the topic/fix-sighting-context-mangling branch April 26, 2021 12:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tobim tobim tobim left review comments

@dominiklohmann dominiklohmann dominiklohmann approved these changes

@satta satta Awaiting requested review from satta

@lava lava Awaiting requested review from lava

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0snap @tobim @dominiklohmann
0