This repository was archived by the owner on May 29, 2024. It is now read-only.
Handle VAST matcher CLI changes in pyvast-threatbus #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55c6d5b to
c8bbd2b
Compare
dominiklohmann
approved these changes
Apr 12, 2021
There was a problem hiding this comment.
I ran this locally and can confirm that the tests work with a recent build of VAST with the Matcher plugin.
We should think about running these tests as part of the Matcher CI. Obviously this cannot happen directly in this repository, but having the tests automated would save a lot of time in future reviews.
I'm approving this PR as-is, but please reword the first changelog entry as I suggested.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
The VAST matcher is now available as plugin. That rewrite led to a CLI change.
This PR updates
pyvast-threatbusto use the correct CLI options to work with the VAST matcher plugin. It also fixes a small bug where the wrong function name was called for mapping matcher results to STIX-2 sightings.📝 Checklist
🎯 Review Instructions