8000 Update tfjs-node to 1.2.9. by kangyizhang · Pull Request #1983 · tensorflow/tfjs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update tfjs-node to 1.2.9. #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 6, 2019
Merged

Update tfjs-node to 1.2.9. #1983

merged 4 commits into from
Sep 6, 2019

Conversation

kangyizhang
Copy link
Contributor
@kangyizhang kangyizhang commented Sep 5, 2019 •
edited by nsthorat
Loading

This change is Reviewable

8000
@kangyizhang kangyizhang requested a review from nsthorat September 5, 2019 20:34
@nsthorat
Copy link
Contributor
nsthorat commented Sep 5, 2019

Looks like we need to update the kernels from this PR: #1829

cc @dsmilkov

@kangyizhang
Copy link
Contributor Author

@nsthorat yes I'm working on it. Seems like it needs two part of changes:

  1. add default value for mask params
  2. normalization of out of range begin/end and negative strides makes TF C api shows different result. Filed Normalization of out of range start/end and negative stride breaks stridedSlice #1984

@googlebot googlebot added cla: no and removed cla: yes labels Sep 6, 2019
@tensorflow tensorflow deleted a comment from googlebot Sep 6, 2019
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@dsmilkov
Copy link
Contributor
dsmilkov commented Sep 6, 2019

I just pushed to this branch and made all tests to pass - you should be good to go. For the diff see commit: 6290323

@dsmilkov dsmilkov added cla: yes and removed cla: no labels Sep 6, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Sep 6, 2019
@kangyizhang
Copy link
Contributor Author

@googlebot I consent.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@kangyizhang kangyizhang requested a review from dsmilkov September 6, 2019 17:01
dsmilkov
dsmilkov approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor
@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, 1 of 1 files at r3.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @dsmilkov and @nsthorat)

@kangyizhang kangyizhang merged commit c55fad6 into master Sep 6, 2019
@kangyizhang kangyizhang deleted the b1.2.9 branch September 6, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsmilkov dsmilkov dsmilkov approved these changes

@nsthorat nsthorat Awaiting requested review from nsthorat

Assignees
No one assigned
Labels
cla: yes INTERNAL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kangyizhang @nsthorat @googlebot @dsmilkov
0