Fixes include path broken by virtual pip packaging #29561
Conversation
Signed-off-by: Bairen Yi <yibairen.byron@bytedance.com>
| unzip $WHEEL -d $WHEEL_TMPDIR > /dev/null | ||
| rm $WHEEL | ||
| pushd $WHEEL_TMPDIR > /dev/null | ||
| mv tensorflow_core/include/tensorflow{_core,} |
There was a problem hiding this comment.
I think we only need this line but immediately after line 172 above:
mv tensorflow tensorflow_core # this is line 172
mv tensorflow_core/include/tensorflow{_core,} # this is the lineThis way we don't unzip and rezip the wheel and potentially breaking the contract in manifest.
There was a problem hiding this comment.
I'm going to approve as is for now and fix that tomorrow after we have new pips
There was a problem hiding this comment.
That’s weird, why do we have them under tensorflow_core in the first place, before bdist_wheel? I’ll take a closer look at your suggested fix.
There was a problem hiding this comment.
This way we don't unzip and rezip the wheel and potentially breaking the contract in manifest.
The MANIFEST.in file seems long broken anyway. Do we need to fix them as well?
PiperOrigin-RevId: 252255891
|
Oh this should not be merged...ping @perfinion to help sort out this patch in a proper way. |
Ping @mihaimaruseac for review. Ping @lark as this is a work-related contribution.
This fixes horovod/horovod#1129 in our in-house nightly build.