8000 feat(lang): init py env by generating the bulid.envd by kemingy · Pull Request #827 · tensorchord/envd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(lang): init py env by generating the bulid.envd #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 31, 2022
Merged

feat(lang): init py env by generating the bulid.envd #827

merged 5 commits into from
Aug 31, 2022

Conversation

kemingy
Copy link
Member
@kemingy kemingy commented Aug 30, 2022

Signed-off-by: Keming kemingyang@tensorchord.ai

includes:

  • requirements.txt
  • env.yaml

maybe later:

  • pyproject.toml
  • setup.cfg
  • setup.py

@kemingy
feat(lang): init py env by generating the bulid.envd from existing pr…
8000
0fe56d8 
…oject

Signed-off-by: Keming <kemingyang@tensorchord.ai>
@muniu-bot muniu-bot bot added the approved label Aug 30, 2022
kemingy added 2 commits August 30, 2022 15:27
@kemingy
add test
ec6d524 
Signed-off-by: Keming <kemingyang@tensorchord.ai>
@kemingy
fix test
1c60c63 
Signed-off-by: Keming <kemingyang@tensorchord.ai>
@kemingy kemingy marked this pull request as ready for review August 30, 2022 08:41
@kemingy kemingy linked an issue Aug 30, 2022 that may be closed by this pull request
feat: Support generating build.envd from user's existing project like buildpacks #698
Closed
kemingy added 2 commits August 30, 2022 16:46
@kemingy
fix lint
bd55642 
Signed-off-by: Keming <kemingyang@tensorchord.ai>
@kemingy
only use the first file
a884a35 
Signed-off-by: Keming <kemingyang@tensorchord.ai>
@aseaday
Copy link
Member
aseaday commented Aug 30, 2022

Could we test it under root users?

@kemingy
Copy link
Member Author
kemingy commented Aug 31, 2022

Could we test it under root users?

What do you mean by "under root users"? Run the envd init with sudo?

@aseaday
Copy link
Member
aseaday commented Aug 31, 2022 •
edited
Loading

Could we test it under root users?

What do you mean by "under root users"? Run the envd init with sudo?

such as

# envd init

sometimes ,root users executions will cause some unexpected error for file permission.

@kemingy
Copy link
Member Author
kemingy commented Aug 31, 2022

Could we test it under root users?

What do you mean by "under root users"? Run the envd init with sudo?

such as

# envd init

sometimes ,root users executions will cause some unexpected error for file permission.

Is it related to #666?

Do we need to add the root test to all the e2e tests?

@aseaday
Copy link
Member
aseaday commented Aug 31, 2022

Could we test it under root users?

What do you mean by "under root users"? Run the envd init with sudo?

such as

# envd init

sometimes ,root users executions will cause some unexpected error for file permission.

Is it related to #666?

Do we need to add the root test to all the e2e tests?

I think we could do all e2e tests in root users. WDYT @gaocegege

aseaday
aseaday approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member
@aseaday aseaday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, e2e root test under root could be a CI task

@muniu-bot
Copy link
muniu-bot bot commented Aug 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aseaday, gaocegege, kemingy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [aseaday,gaocegege,kemingy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kemingy
Copy link
Member Author
kemingy commented Aug 31, 2022

I'm going to merge this one. We can discuss the root user test in #666.

@kemingy kemingy merged commit 404de31 into tensorchord:main Aug 31, 2022
@kemingy kemingy deleted the init_py_env branch August 31, 2022 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aseaday aseaday aseaday approved these changes

@gaocegege gaocegege gaocegege approved these changes

@terrytangyuan terrytangyuan Awaiting requested review from terrytangyuan

@VoVAllen VoVAllen Awaiting requested review from VoVAllen VoVAllen is a code owner

@zwpaper zwpaper Awaiting requested review from zwpaper zwpaper is a code owner

Assignees
No one assigned
Labels
approved
Projects
No open projects
envd sprint board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Support generating build.envd from user's existing project like buildpacks
3 participants
@kemingy @aseaday @gaocegege
0