-
Notifications
You must be signed in to change notification settings - Fork 92
DT-3027: Setup Basic Super Form #2765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
7db11d3
to
b94a2c1
Compare
782dfc5
to
b583c4d
Compare
GiantRobots
reviewed
Jun 23, 2025
b583c4d
to
4f755cf
Compare
rossnelson
commented
Jun 23, 2025
@@ -0,0 +1,134 @@ | |||
// @vitest-environment jsdom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test feels pointless. is there a better way to unit test svelte components?
8f2f5dc
to
713988b
Compare
Alex-Tideman
approved these changes
Jun 26, 2025
Adds foundational form infrastructure using SuperForms for SPA applications. Includes SuperForms integration with Zod validation, comprehensive documentation, and Storybook examples. Key implementation details: - SuperForms dependency with Zod for schema validation - Example components demonstrating various form patterns - Documentation covering both wrapper and raw SuperForms usage - Storybook integration for interactive form examples - Testing infrastructure setup with proper mocking - CLAUDE.md documentation for project coding standards The infrastructure provides a foundation for building robust forms with client-side validation, loading states, error handling, and proper accessibility support.
106fbc3
to
ad40516
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
This PR implements direct SuperForms integration for form handling in the UI. It adds a minimal wrapper utility and documentation to help developers use SuperForms effectively.
Key changes:
createSPAForm
wrapper that configures SuperForms with SPA defaultsScreenshots (if applicable) 📸
Storybook story shows a simple form with text input that successfully posts form data to the actions pane when submitted.
Form Usage
Forms use direct SuperForms integration:
Benefits ✨
Testing 🧪
createSPAForm
function with mocked SuperFormsSteps to test: 🚶♂️🚶♀️
pnpm stories:dev
to start Storybook/basic
route to see form in actionpnpm test src/lib/utilities/form/create-spa-form.test.ts
to verify testspnpm check
andpnpm lint
to verify code qualityChecklists ✅
Completed
Issue(s) closed
Completes DT-3027 SuperForms integration - adds form handling with direct SuperForms usage.
Closes DT-3034, DT-3028, DT-3029, DT-3032