8000 Only query workflow metadata for running workflows by Alex-Tideman · Pull Request #2560 · temporalio/ui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Only query workflow metadata for running workflows #2560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 19, 2025

Conversation

Alex-Tideman
Copy link
Contributor
@Alex-Tideman Alex-Tideman commented Feb 18, 2025

Description & motivation 💭

Users can run into NDEs for workflows closed in the past while visiting Workflow Execution page due to Workflow Metadata query on page load. This PR changes that logic to only fetch the query on page load of running workflows. When a workflow is closed, a user can click on the Current Details accordion to run the query to get the current details.

The Workflow Metadata query will run on page load of the Query page if the workflow is closed and the query hasn't been run yet (Current Details accordion clicked).

As an additional feature, I've added an 'Update Details' button on the Current Details accordion for running workflows for a user to update the details without having to reload the whole page.

Also includes fix to add our markdown.reset css to the ui-server renderer endpoint to correctly render markdown on self-hosted.

The one call-out I want to make is that the Current Details accordion will now always be visible, for running or closed workflows. For running, it might not have any current details on page load, but it could later when a user wants to update the details. For closed, a user won't know if it has any current details until it's clicked and queried.

Screenshots (if applicable) 📸

Screenshot 2025-02-18 at 12 27 46 PM Screenshot 2025-02-18 at 12 26 35 PM Screenshot 2025-02-18 at 12 25 35 PM Screenshot 2025-02-18 at 12 36 53 PM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

Copy link
vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 2:10am

Copy link
Contributor
@laurakwhit laurakwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some non-blocking comments below, but otherwise 🚀

@Alex-Tideman Alex-Tideman merged commit 290fcf4 into main Feb 19, 2025
15 checks passed
@Alex-Tideman Alex-Tideman deleted the remove-metadata-query-for-closed-workflows branch February 19, 2025 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0