Only query workflow metadata for running workflows #2560
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Users can run into NDEs for workflows closed in the past while visiting Workflow Execution page due to Workflow Metadata query on page load. This PR changes that logic to only fetch the query on page load of running workflows. When a workflow is closed, a user can click on the Current Details accordion to run the query to get the current details.
The Workflow Metadata query will run on page load of the Query page if the workflow is closed and the query hasn't been run yet (Current Details accordion clicked).
As an additional feature, I've added an 'Update Details' button on the Current Details accordion for running workflows for a user to update the details without having to reload the whole page.
Also includes fix to add our markdown.reset css to the ui-server renderer endpoint to correctly render markdown on self-hosted.
The one call-out I want to make is that the Current Details accordion will now always be visible, for running or closed workflows. For running, it might not have any current details on page load, but it could later when a user wants to update the details. For closed, a user won't know if it has any current details until it's clicked and queried.
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?