8000 Add Schedules cron string description by laurakwhit · Pull Request #2549 · temporalio/ui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Schedules cron string description #2549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 10, 2025

Conversation

laurakwhit
Copy link
Contributor
@laurakwhit laurakwhit commented Feb 10, 2025

Description & motivation 💭

  • Adds cron string description to create Schedule page
  • Adjusts spacing and secondary text color under Schedule Spec on the create Schedules page
  • Updates CodeBlock component background

Screenshots (if applicable) 📸

Before After
Screenshot 2025-02-10 at 11 47 19 AM Screenshot 2025-02-10 at 12 10 12 PM
Screenshot 2025-02-10 at 11 47 29 AM Screenshot 2025-02-10 at 12 10 32 PM
Before (day) Before (night) After (day) After (night)
Screenshot 2025-02-10 at 11 44 41 AM Screenshot 2025-02-10 at 11 44 55 AM Screenshot 2025-02-10 at 11 35 47 AM Screenshot 2025-02-10 at 11 35 55 AM
Screenshot 2025-02-10 at 11 45 41 AM Screenshot 2025-02-10 at 11 45 52 AM Screenshot 2025-02-10 at 11 36 11 AM Screenshot 2025-02-10 at 11 36 04 AM
Screenshot 2025-02-10 at 11 46 21 AM Screenshot 2025-02-10 at 11 46 33 AM Screenshot 2025-02-10 at 11 36 19 AM Screenshot 2025-02-10 at 11 36 27 AM
Before After
Screenshot 2025-02-10 at 11 49 51 AM Screenshot 2025-02-10 at 1 57 32 PM
Screenshot 2025-02-10 at 11 50 07 AM Screenshot 2025-02-10 at 1 57 40 PM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

DT-2736

Docs

Any docs updates needed?

Copy link
vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 10:37pm

@laurakwhit laurakwhit marked this pull request as ready for review February 10, 2025 19:12
@laurakwhit laurakwhit requested review from rossedfort and a team as code owners February 10, 2025 19:12
Comment on lines 126 to 132
content={`┌───────────── minute (0 - 59)
│ ┌───────────── hour (0 - 23)
│ │ ┌───────────── day of the month (1 - 31)
│ │ │ ┌───────────── month (1 - 12)
│ │ │ │ ┌───────────── day of the week (0 - 6) (Sunday to Saturday)
│ │ │ │ │
* * * * * <command to execute>`}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible, love it

@laurakwhit laurakwhit merged commit ff85b37 into main Feb 10, 2025
15 checks passed
@laurakwhit laurakwhit deleted the schedules-cron-string-description branch February 10, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0