8000 Workflow Filter Options by Alex-Tideman · Pull Request #2546 · temporalio/ui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Workflow Filter Options #2546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 10, 2025
Merged

Workflow Filter Options #2546

merged 5 commits into from
Feb 10, 2025

Conversation

Alex-Tideman
Copy link
Contributor
@Alex-Tideman Alex-Tideman commented Feb 7, 2025

Description & motivation 💭

Better UX for the various options to filter Workflows.

Move the Download JSON and Configure Table options to the table footer.
Move the View Raw Query and Show/Hide Child Workflows option to the Filter Menu.

Screenshots (if applicable) 📸

Screenshot 2025-02-07 at 3 33 34 PM Screenshot 2025-02-07 at 3 33 51 PM Screenshot 2025-02-07 at 3 34 07 PM Screenshot 2025-02-07 at 3 34 20 PM Screenshot 2025-02-07 at 3 34 33 PM Screenshot 2025-02-07 at 3 34 41 PM Screenshot 2025-02-07 at 3 34 55 PM Screenshot 2025-02-07 at 3 37 01 PM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

Copy link
vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 9:52pm

@rossedfort
Copy link
Contributor

I like this, the only thing I might change is instead of Hide Raw Query when you have the search input open, I might change it to the filter icon and Show Filters in the tooltip instead
Screenshot 2025-02-10 at 2 40 14 PM

@Alex-Tideman
Copy link
Contributor Author
Screenshot 2025-02-10 at 3 49 15 PM

@Alex-Tideman Alex-Tideman merged commit e8cc3c0 into main Feb 10, 2025
15 checks passed
@Alex-Tideman Alex-Tideman deleted the workflow-search-options branch February 10, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0