Add new responsive styles to input on api pagination #2333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Let's point this at |
laurakwhit
reviewed
Sep 18, 2024
laurakwhit
requested changes
Oct 7, 2024
| @@ -226,7 +226,7 @@ | |||
| <Input | |||
| icon="search" | |||
| id="api-pagination-search-input" | |||
| class="grow" | |||
| class="w-full sm:w-1/2" | |||
There was a problem hiding this comment.
I think we want to keep this grow
Suggested change
| class="w-full sm:w-1/2" | |
| class="grow" |
| Before | After |
|---|---|
There was a problem hiding this comment.
Let me know if this seems better! Thank you Laura! <3
simplify with flex-wrap Co-authored-by: Laura Whitaker <laura.whitaker@temporal.io>
Add better responsive styles Co-authored-by: Laura Whitaker <laura.whitaker@temporal.io>
laurakwhit
approved these changes
Oct 8, 2024
Co-authored-by: Laura Whitaker <laura.whitaker@temporal.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust responsive breakpoints for namespace filtering
This adds a change to the input and nav styles on the API pagination component in holocene to fix breakpoints for namespace filtering.
MD
XS
LG
XL