Add Timeline view with labs guard #1445
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
| @@ -0,0 +1,3 @@ | |||
| import { persistStore } from './persist-store'; | |||
|
|
|||
| export const labsMode = persistStore('labsMode', false, true); | |||
There was a problem hiding this comment.
Might be nice if we could do something like this
const labsParam = derived([page], ([$page]) =>
$page.url.searchParams.get('labs'),
);
const updateLabsMode: StartStopNotifier<boolean> = (set) => {
return labsParam.subscribe((labs) => {
if (labs === 'true') {
set(true);
} else if (labs === 'false') {
set(false);
}
});
};with the persistStore so we don't have to be on the same page where the LabsModeGuard is to update the setting.
There was a problem hiding this comment.
Yeah I was contemplating that. The only issue is if someone adds ?labs=true on a page that doesn't have a LabsGuard, they might expect the page to change.
But I think that's okay, I like this better than needing to be on a LabsGuard page
There was a problem hiding this comment.
So I'm going to leave it as is, adding a StartStopNotifier to the persistStore overrides the custom updater function that sets localStorage.
I can move this logic out of the LabsModeGuard and to the top level layout, but for now I want to keep it isolated to the guard. We can revisit as we add more labs.
Description & motivation 💭
Add new Timeline view hidden behind labs flag.
To turn on, set labs=true as a query param on the Workflow Details page. That will set a localStorage flag to true so you don't have to keep adding the param. To turn off, set labs=false.
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?