Add go.work file to root #1410
Merged
Add go.work file to root #1410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
|
keeping this open until fixing the e2e tests in the PR. Haven't freed up some time to do this yet |
No worries @feedmeapples, we are currently migrating the e2e test utils away from Go, and have some flakey tests. This should be resolved once we merge main into this branch after merging #1414 |
rossedfort
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
This PR adds a
go.workfile to the root of the project. This allowsgoplsand the tools that leverage it, like VSCodes go extension, to be aware that there is a go module in this project not at the root of the project. Whengoplsis aware of the module functionality like autocomplete and goto work as expected when opening the project from root without the project living in yourGOPATH.Ref
https://go.dev/ref/mod#workspaces
https://github.com/golang/tools/blob/master/gopls/doc/workspace.md
Screenshots (if applicable) 📸
Screen.Recording.2023-06-05.at.1.24.02.PM.mov
Design Considerations 🎨
N/A
Testing 🧪
Manual validation in VSCode
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Pull the branch, validate that your go extension of choice works.
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?