8000 Fix action text on Cancel modal by laurakwhit · Pull Request #1415 · temporalio/ui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix action text on Cancel modal #1415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 7, 2023
Merged

Fix action text on Cancel modal #1415

merged 2 commits into from
Jun 7, 2023

Conversation

laurakwhit
Copy link
Contributor
@laurakwhit laurakwhit commented Jun 6, 2023 •
edited
Loading

Description & motivation 💭

  • Changes back action text on Cancel modal to Confirm
  • Disabled cancellation button if no Running workflows are selected

Screenshots (if applicable) 📸

Single Bulk Bulk disabled
Screenshot 2023-06-06 at 1 57 43 PM Screenshot 2023-06-06 at 1 54 45 PM Screenshot 2023-06-06 at 2 24 00 PM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

  • Verify it says Confirm on the Cancel modal when requesting cancellation
    • from the workflows list view
    • from the workflow detail page
  • Verify the cancellation button is disabled if there are no Running workflows selected

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

@vercel
Copy link
vercel bot commented Jun 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
holocene ⬜️ Ignored (Inspect) Jun 6, 2023 8:26pm

@laurakwhit laurakwhit changed the title Change back action text on Cancel modal to Confirm Fix action text on Cancel modal Jun 6, 2023
@laurakwhit laurakwhit marked this pull request as ready for review June 6, 2023 19:40
@laurakwhit laurakwhit requested review from rossedfort and a team as code owners June 6, 2023 19:40
@laurakwhit laurakwhit force-pushed the fix-confirm-text-on-cancel-modal branch from 1e288f8 to fc7f4d7 Compare June 6, 2023 19:56
@laurakwhit laurakwhit merged commit e96f9df into main Jun 7, 2023
@laurakwhit laurakwhit deleted the fix-confirm-text-on-cancel-modal branch June 7, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekinney stevekinney stevekinney approved these changes

@rossedfort rossedfort Awaiting requested review from rossedfort rossedfort is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurakwhit @stevekinney
0