8000 Add Navigator to JSON View by Alex-Tideman · Pull Request #1360 · temporalio/ui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Navigator to JSON View #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2023
Merged

Add Navigator to JSON View #1360

merged 2 commits into from
May 12, 2023

Conversation

Alex-Tideman
Copy link
Contributor
@Alex-Tideman Alex-Tideman commented May 12, 2023 •
edited
Loading

Description & motivation 💭

With really large event histories (tens of thousands), the JSON view will hang and crash the browser since we show all events and use syntax highlighting.

This PR prevents that from happening by rendering only one event at a time but with controls to navigate quickly across all the events. The controls will be:

  1. Left/right arrow keys
  2. Left/right arrows to click
  3. Range Input (slider)
  4. Input to pick a specific event id

Screenshots (if applicable) 📸

JSONViewNavigator.mov

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

@Alex-Tideman Alex-Tideman requested review from rossedfort and a team as code owners May 12, 2023 14:13
@vercel
Copy link
vercel bot commented May 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2023 4:31pm

@Alex-Tideman Alex-Tideman requested a review from laurakwhit May 12, 2023 14:14
@rossedfort
Copy link
Contributor

Lgtm, only thing I would say is that maybe workflow-json-navigator.svelte should go in src/lib/components instead of src/lib/holocene cause it has some business logic

@Alex-Tideman
Copy link
Contributor Author
8000

👍 Yup good call. Moved it.

@Alex-Tideman Alex-Tideman merged commit e20be08 into main May 12, 2023
@Alex-Tideman Alex-Tideman deleted the json-view-refactor branch May 12, 2023 17:51
laurakwhit
laurakwhit approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor
@laurakwhit laurakwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of the Slider 💪 Some small UI things below, but other than that lgtm!

@laurakwhit laurakwhit mentioned this pull request May 12, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurakwhit laurakwhit laurakwhit approved these changes

@rossedfort rossedfort rossedfort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alex-Tideman @rossedfort @laurakwhit
0