10000 Async Prism highlighting by Alex-Tideman · Pull Request #1337 · temporalio/ui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Async Prism highlighting #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 1, 2023
Merged

Async Prism highlighting #1337

merged 3 commits into from
May 1, 2023

Conversation

Alex-Tideman
Copy link
Contributor
@Alex-Tideman Alex-Tideman commented May 1, 2023

Description & motivation 💭

Allow async highlight of CodeBlock in a Web Worker to unblock main thread for rendering. Default CodeBlock to use async prop for highlighting.

On error of web worker (such as not finding the web worker file), fall back to using the synchronous highlighting.

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

@Alex-Tideman Alex-Tideman requested review from rossedfort and a team as code owners May 1, 2023 14:36
@vercel
Copy link
vercel bot commented May 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview May 1, 2023 2:36pm

@Alex-Tideman Alex-Tideman requested review from GiantRobots and removed request for rossedfort May 1, 2023 14:36
@Alex-Tideman Alex-Tideman merged commit 708ea59 into main May 1, 2023
@Alex-Tideman Alex-Tideman deleted the async-prism-highlighting branch May 1, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0