8000 DT-76 - fix up accordion action styles by rossedfort · Pull Request #1304 · temporalio/ui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

DT-76 - fix up accordion action styles #1304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

rossedfort
Copy link
Contributor

Description & motivation 💭

  • Use <IconButton /> instead of <Button /> in the Histoire story for <Accordion />
  • center align <Accordion />'s action so it's inline with the open/close caret.

Screenshots (if applicable) 📸

before

Screen Shot 2023-04-17 at 2 55 26 PM

after

Screen Shot 2023-04-17 at 2 55 17 PM

Design Considerations 🎨

N/a

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

  • visually verify changes in holocene preview URL

Checklists

N/a

Draft Checklist

Merge Checklist

Issue(s) closed

N/a

Docs

N/a

Any docs updates needed?

@rossedfort rossedfort requested a review from laurakwhit April 17, 2023 20:56
@vercel
Copy link
vercel bot commented Apr 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview Apr 17, 2023 8:56pm

@rossedfort rossedfort merged commit e7f1cc5 into main Apr 18, 2023
@rossedfort rossedfort deleted the DT-76-fix-accordion-icon-border branch April 18, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0