8000 [DT-158] Core UI Scrub by laurakwhit · Pull Request #1044 · temporalio/ui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[DT-158] Core UI Scrub #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Jan 17, 2023
Merged

[DT-158] Core UI Scrub #1044

merged 25 commits into from
Jan 17, 2023

Conversation

laurakwhit
Copy link
Contributor
@laurakwhit laurakwhit commented Jan 12, 2023 •
edited
Loading

What was changed

  • Background color
  • Table border color and width
  • Primary button color
  • Border radius on tables, panels, cards, etc.
  • Workflow Status and Badge colors
  • Hover state for copy and filter buttons on workflow row
  • Workflow details have been moved to
    • Summary section with
      • Responsive grid layout
      • Copy buttons on additional info.
    • Relationships section with
      • Additional execution run IDs with links for First, Next, and Previous
      • Badges for Parent, Children, First, Next, and Previous count
  • Styling of retry button
  • Direction of background gradient
    • Background of filter & copy buttons on workflow row
  • Pagination arrows
    • api-pagination.svelte now uses Icons
    • Increased contrast of grays
  • Tables on Namespace details page are now on Card with white background
  • Border and hover state on namespace list under Select a Namespace pop out

Why?

✨

Checklist

  1. Closes: DT-158

  2. How was this tested:

  • Complete manual testing for confirmation of all visual changes
  1. Any docs updates needed? n/a

@vercel
Copy link
vercel bot commented Jan 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
holocene ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 17, 2023 at 4:57PM (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 17, 2023 at 4:57PM (UTC)

@cypress
Copy link
cypress bot commented Jan 12, 2023 •
edited
Loading


Test summary

82 • 0 • 5 • 0

Run details
Project Temporal UI
Status Passed
Commit 7e449b69fc ℹ️
Started Jan 17, 2023 5:03 PM
Ended Jan 17, 2023 5:07 PM
Duration 04:45 💡
OS Linux Ubuntu - 22.04
Browser Chrome 108

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@laurakwhit @rossedfort
Fix snapshot tests
c806988 
Co-authored-by: Ross Edfort <ross.edfort@temporal.io>
@laurakwhit laurakwhit force-pushed the DT-158-Core-UI-Scrub branch from 6ddf3fc to c806988 Compare January 12, 2023 22:21
@laurakwhit laurakwhit force-pushed the DT-158-Core-UI-Scrub branch from 4c69193 to 4f8e420 Compare January 13, 2023 17:20
@laurakwhit laurakwhit force-pushed the DT-158-Core-UI-Scrub branch from 4f8e420 to cffd68a Compare January 13, 2023 17:23
@laurakwhit laurakwhit force-pushed the DT-158-Core-UI-Scrub branch from cffd68a to e53bf8a Compare January 13, 2023 17:31
@Alex-Tideman
Copy link
Contributor

The scrub looks awesome! Somehow it makes the UI feel futuristic/sci-fi but at the same time I'd give it to my 3 year as a stuffy to sleep with.

@laurakwhit laurakwhit marked this pull request as ready for review January 13, 2023 17:50
@laurakwhit laurakwhit requested a review from a team as a code owner January 13, 2023 17:50
@laurakwhit laurakwhit requested review from tigernaut, Alex-Tideman and rossedfort and removed request for tigernaut January 13, 2023 17:50
rossedfort
rossedfort approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor
@rossedfort rossedfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧽

@Alex-Tideman
Copy link
Contributor

👍 good with last two commits

@laurakwhit laurakwhit force-pushed the DT-158-Core-UI-Scrub branch from 1385e03 to b860e74 Compare January 17, 2023 17:01
@laurakwhit laurakwhit merged commit 0c3b3dd into main Jan 17, 2023
@laurakwhit laurakwhit deleted the DT-158-Core-UI-Scrub branch January 17, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alex-Tideman Alex-Tideman Alex-Tideman approved these changes

@rossedfort rossedfort rossedfort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurakwhit @Alex-Tideman @rossedfort
0