DT-202 - workflow action flags #1037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
| <WorkflowRunLayout cancelEnabled={!isCloud} signalEnabled={!isCloud}> | ||
| <WorkflowRunLayout | ||
| cancelEnabled={!$settings.workflowCancelDisabled} | ||
| signalEnabled={!$settings.workflowSignalDisabled} |
There was a problem hiding this comment.
Do we still need the isCloud check here? Like how would we turn on workflowSignalDisabled for cloud folks?
There was a problem hiding this comment.
Yep good call, fixed in 13cbc10
There was a problem hiding this comment.
Nice this looks real good now.
and add tests
Alex-Tideman
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Use the new configuration flags added in temporalio/ui-server#265
Also re-design the Namespace details page
large screen sizes:
small screen sizes:
Why?
So that people can individually toggle workflow actions in their namespaces
Checklist
Closes
How was this tested: