8000 Add types and tests for isLocalActivityMarkerEvent by stevekinney · Pull Request #994 · temporalio/ui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add types and tests for isLocalActivityMarkerEvent #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 13, 2022

Conversation

stevekinney
Copy link
Contributor

Removes explicit any type for isLocalActivityMarkerEvent.

Adds unit tests for isLocalActivityMarkerEvent.

@Alex-Tideman, question for you: should we iterate over the payloads to see if there are any with ActivityType or activity_type?

@vercel
Copy link
vercel bot commented Dec 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
holocene ✅ Ready (Inspect) Visit Preview Dec 13, 2022 at 7:03PM (UTC)
ui ✅ Ready (Inspect) Visit Preview Dec 13, 2022 at 7:03PM (UTC)

@cypress
Copy link
cypress bot commented Dec 13, 2022



Test summary

93 0 0 0


Run details

Project Temporal UI
Status Passed
Commit 329ab2f1cc ℹ️
Started Dec 13, 2022 6:47 PM
Ended Dec 13, 2022 6:52 PM
Duration 04:45 💡
OS Linux Ubuntu - 22.04
Browser Chrome 108

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Removes explicit `any` type for `isLocalActivityMarkerEvent`.

Adds unit tests for `isLocalActivityMarkerEvent`.

@Alex-Tideman, question for you: should we iterate over the payloads to see if there are _any_ with `ActivityType` or `activity_type`?

Add types and tests for isLocalActivityMarkerEvent

Removes explicit `any` type for `isLocalActivityMarkerEvent`.

Adds unit tests for `isLocalActivityMarkerEvent`.

@Alex-Tideman, question for you: should we iterate over the payloads to see if there are _any_ with `ActivityType` or `activity_type`?

Loosen type to just what we care about
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0