8000 Prevent pending activity negative attempts / max attempts by Alex-Tideman · Pull Request #987 · temporalio/ui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Prevent pending activity negative attempts / max attempts #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 12, 2022
Merged

Prevent pending activity negative attempts / max attempts #987

merged 2 commits into from
Dec 12, 2022

Conversation

Alex-Tideman
Copy link
Contributor
@Alex-Tideman Alex-Tideman commented Dec 10, 2022 •
edited
Loading

What was changed

Check for null values instead of == 0 for max attempts. Since maximumAttempts can be a number or null, update the code for the maximum attempts and attempts left to prevent negative numbers (i.e. null - 6 = -6 because Javascript). If maximumAttempts is null or 0, show Unlimited label.

   /** PendingActivityInfo maximumAttempts */
   maximumAttempts?: (number|null);

Why?

Prevent confusing negative attempts

@Alex-Tideman Alex-Tideman merged commit fad2aaa into main Dec 12, 2022
@Alex-Tideman Alex-Tideman deleted the pending-activity-negative-attempts branch December 12, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossedfort rossedfort rossedfort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alex-Tideman @rossedfort
155D
0