8000 Fix pagination controls UI on window resize by laurakwhit · Pull Request #986 · temporalio/ui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix pagination controls UI on window resize #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

laurakwhit
Copy link
Contributor

What was changed

Updates the width being passed to getFloatStyle in the Holocene Pagination component.

Why?

Fixes wonkiness of pagination controls on window resize.

Screenshot 2022-12-09 at 12 25 23 PM

Checklist

  1. Closes: n/a

  2. How was this tested:

  • On a smaller breakpoint (e.g. md or smaller), change the history view (e.g. Compact --> JSON) and then increase the screen size to lg or larger
    • Verify the pagination control are in the correct position
  1. Any docs updates needed? n/a

@vercel
Copy link
vercel bot commented Dec 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
holocene ✅ Ready (Inspect) Visit Preview Dec 9, 2022 at 8:25PM (UTC)
ui ✅ Ready (Inspect) Visit Preview Dec 9, 2022 at 8:25PM (UTC)

@cypress
Copy link
cypress bot commented Dec 9, 2022



Test summary

93 0 0 0


Run details

Project Temporal UI
Status Passed
Commit cbbdce54ae ℹ️
Started Dec 9, 2022 8:33 PM
Ended Dec 9, 2022 8:38 PM
Duration 04:35 💡
OS Linux Ubuntu - 22.04
Browser Chrome 108

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@laurakwhit laurakwhit merged commit 2567905 into main Dec 12, 2022
@laurakwhit laurakwhit deleted the fix-pagination-float-on-resize branch December 12, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0